DESCRIPTION

TMF: Implementation of XML analysis requirements

Change-Id: I7853f35020064e72656bfd7d9e701f49f20d736d
Signed-off-by: Keshawn Lopez xxx@xxx.xxx


COMMENTS

author: Keshawn Lopez
date: 2014-03-26 16:09:39.000000000

Uploaded patch set 2.

-------------------------------------
author: Annalise Jimenez
date: 2014-03-26 18:38:29.000000000

Patch Set 2: Code-Review-1

(1 comment)

Sounds good so far.

Could you add unit tests using the test_valid file from xml.core.tests/test_xml_files?

Line:178, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfAnalysisModuleHelperXml.java -> To avoid casting, you could use the XmlUtils.getChildElement(fSourceElement, TmfXmlStrings.EVENT_HANDLER) instead.

-------------------------------------
author: Brenden Conley
date: 2014-03-26 18:49:00.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6104/

-------------------------------------
author: Brenden Conley
date: 2014-03-26 19:37:45.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6104/ : SUCCESS

-------------------------------------
