DESCRIPTION

Systemtap: More Probe & Function view fixes.

-Obtain static probes with a call to "stap --dump-probe-types" rather
than with a configuration file.
-Improve layout & organization of entries in the Probe Alias View.
-Correct the way probe groups are added to scripts (EBZ#431260).
-Create SharedParser to share stap -vp1 dumps among Probe & Function
parsers.
-Restore "View Definition" feature for Probe Alias view.
-Clean & improve "View Definition"'s means of searching for script
contents.
-Replace DefinitionAction with DefinitionHandler, and migrate plugin
implementation from Actions to Commands.
-Format .systemtap.ui.ide/plugin.xml.
-Update code completion for probes & its associated tests.

Change-Id: I24a8c89ea9fdd372efdff13f18d8bcebf5957d0b
Signed-off-by: Landon Wilkins xxx@xxx.xxx


COMMENTS

author: Landon Wilkins
date: 2014-04-01 18:38:15.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-04-01 18:38:21.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6177/

-------------------------------------
author: Brenden Conley
date: 2014-04-01 19:10:53.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6177/ : FAILURE

-------------------------------------
author: Erick Ross
date: 2014-04-01 19:20:01.000000000

Patch Set 3:

(10 comments)

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/actions/BrowserViewAction.java -> Missing license header.

Line:28, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/META-INF/MANIFEST.MF -> I would rather see you using Require-Bundle as rpm autodependencies don't work for Import-Package.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/structures/ProbevarNodeData.java -> Missing license header.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/handlers/DefinitionMenuTester.java -> Missing license header.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/structures/SharedParser.java -> Missing license header.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/structures/ProbeNodeData.java -> Missing license header.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/handlers/DefinitionHandler.java -> Missing license header.

Line:75, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/handlers/DefinitionHandler.java -> Do we needan override that simply calls super?

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/structures/ISearchableNode.java -> Missing license header.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/structures/ISingleTypedNode.java -> Missing license header.

-------------------------------------
author: Gerrit Code Review
date: 2014-04-24 13:56:27.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
