DESCRIPTION

[WIP] tmf: coalescing across event providers

Change-Id: I971854ba0f062acc0a3480bba90b02ee42082131
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2014-03-19 19:53:37.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-03-19 20:49:43.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6039/

-------------------------------------
author: Brenden Conley
date: 2014-03-19 21:44:44.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6039/ : SUCCESS

-------------------------------------
author: Annalise Jimenez
date: 2014-03-20 15:55:57.000000000

Patch Set 1: Code-Review-1

(4 comments)

Line:213, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> add space after cast

Line:218, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> Shouldn't the method name be getCompatibleRequests? There is no children involved here. Also add either private or protected to method.

Line:343, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> When you call the coalesceChildren method, you already know which coalescedRequest the original request was coalesced to. So why not send this CoalescedEventRequest instead and verify compatibility with it, so that here can just add the child request to that coalescedRequest? That would avoid calling coalesceEventRequest for each child request and rechecking compatibility with all coalesced requests.

Line:466, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> Missing javadoc

-------------------------------------
author: Ricky Reeves
date: 2014-03-21 15:14:31.000000000

Patch Set 1:

(4 comments)

Line:213, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> Done

Line:218, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> Done.

Line:343, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> I think you're right that we can optimize the logic. I'll update that.

Line:466, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component/TmfEventProvider.java -> Done

-------------------------------------
