DESCRIPTION

lttng: Add support for creating a live session in Control view

Change-Id: Ifb31933f8a93437cf976cef71b53cfa5d1f4ec8f
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2014-04-02 19:41:14.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-04-02 19:41:20.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6202/

-------------------------------------
author: Kaeden Tapia
date: 2014-04-02 19:43:15.000000000

Patch Set 4:

I added the dialog with the checkbox.

-------------------------------------
author: Brenden Conley
date: 2014-04-02 20:16:44.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6202/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-04-03 15:03:22.000000000

Patch Set 4: Code-Review-1

(6 comments)

Sorry for the late review. I' ve just installed LTTng 2.4 and I tried to create a live session. I noticed a view things (see inline comments)

Also, the properties view should show if the session is a live session. I hope the tracer is able to provide that information. If not then you don't need change anything. We don't cache of any configuration parameter that are not provided by the tracer (e.g. context added).

Line:248, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> I it's not really needed but add a comment about the group purpose (to be consistent). Also rename to fLiveGroup

Line:653, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> The protocol file is not allowed when using live streaming. The session creation fails. We have to make sure that this combination is not allowed.

Line:662, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> add also a tool tip that also includes the unit (micro seconds)

Line:664, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> Maybe add a VerifyListener that allows the user to enter only digits, see EnableChannelDialog. Also, for channel values we don't pass the default value to the remote and let the remote decide about the default value. From experience the default value can change from release to release and from linux distribution to linux distribution. See EnableChannelDialog how it is handled there.

Line:670, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> please also make the delay text box bigger and align it with the label and text box of the group above

Line:757, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> If you use the VerifyListener that I suggest above you will not need to catch NumberFormatException.

-------------------------------------
author: Kaeden Tapia
date: 2014-04-07 17:03:52.000000000

Patch Set 4:

(6 comments)

Line:248, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> Done

Line:653, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> Done

Line:662, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> Done

Line:664, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> Done.

Line:670, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> Done

Line:757, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/CreateSessionDialog.java -> It still needs to be there because of overflowing. EnableChannelDialog can also overflow and throw the exception.

-------------------------------------
