DESCRIPTION

lttng: Add lttng relayD connector

This allows connections to the lttng session daemon so that live trace
reading can work

Change-Id: Ida7f76f09d3f01a25b67cc552cb5869dc5e4c3a4
Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-04-11 23:24:20.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6384/

-------------------------------------
author: Brenden Conley
date: 2014-04-11 23:34:45.000000000

Patch Set 7: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6384/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-04-14 13:15:36.000000000

Patch Set 7: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6411/

-------------------------------------
author: Brenden Conley
date: 2014-04-14 13:23:19.000000000

Patch Set 7: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6411/ : FAILURE

-------------------------------------
author: Braxton Mccarthy
date: 2014-04-14 21:51:07.000000000

Patch Set 7: Code-Review-1

(104 comments)

The xxx@xxx.xxx / add empty line comments apply to many files, just got bored of writing it after a while ;)

Manfist in lttng2.core.tests should export all its packages.

I feel like many populate() methods could be replaced by constructors instead. It'd be more straightforward, and allow using final fields.

See if getBytes() shouldn't be serialize() instead.

If you internalize plugins correctly, you won't need xxx@xxx.xxx annotations.

Line:52, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConsumer.java -> all fields could be final.

For the Map, maybe add a quick Javadoc what the key/values are, it's not obvious at first glance.

Line:112, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConsumer.java -> That's a weird usage. Shows that maybe Metadata should be a utility class instead. Outside of this patch anyway.

Line:17, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachReturnCode.java -> capital R

xxx@xxx.xxx

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachReturnCode.java -> add empty line after

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IBaseCommand.java -> remove this empty line

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IBaseCommand.java -> remove 'public'

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java xxx@xxx.xxx

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> add empty line below

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> why is this stored as an array? In the one place where you call setStreamList, you do temp.toArray(). And in the one place where you call getStreamList(), you call Arrays.asList() on it. Why not store it as a List directly? (possibly while doing a defensive copy. *cough* ImmutableList!)

Line:71, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> as mentioned elsewhere, this could be the constructor

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetNextIndex.java xxx@xxx.xxx

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectionType.java xxx@xxx.xxx

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectionType.java -> empty line

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayResponse.java -> In all classes where you implement this, you pretty much always do:

  a = new Response();
  a.populate(data);

Shouldn't data be a constructor parameter then? You could still keep this interface, even if it has no methods, for organizational purposes.

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadata.java xxx@xxx.xxx

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionResponse.java -> remove this empty line

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionResponse.java -> add empty line here

just moving things around!

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> not very descriptive, knit a bit more ;)

xxx@xxx.xxx

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> add empty line after

Line:142, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> see if this could be the constructor (final fields!)

Line:159, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> comments

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java xxx@xxx.xxx

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> empty line

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> won't always be 2.4 though

Line:38, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> see if some of these fields couldn't be final and set in a constructor

Line:93, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> add comments

Line:97, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> constructor?

Line:104, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> this bug is marked as resolved, is this still relevant?

Line:108, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> serialize()?

Line:45, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConnectorFactory.java -> The goal of this class is to create connectors, right? Should this method be called "getNewConnector", or similar, then? "connect()" implies you are modifying the state of this class (or of whaterver parameter you are passing).

Line:50, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConnectorFactory.java -> you can put the declarations on the same line

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_NOTSUPPORTED.java -> remove this empty line

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_NOTSUPPORTED.java -> class names should not have all caps. LttngRelaydConnect_Unsupported would be fine

Line:35, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_NOTSUPPORTED.java -> you can remove the "throws IOException" clauses in this class, since they don't throw it.

Line:117, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/StreamInput.java -> oh god, finalize() is bad. Better approach would be to make the class (Auto)Closeable, and have this be the close() method.

Line:2, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> 2014

Line:11, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> add empty line after

Line:44, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Lttng (only cap the first letter)

Line:47, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> private. Also names should be in ALL_CAPS. Variable names, not variable contents ;))

why "// change me"? Isn't this value used in the tests?

Line:53, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Maybe have a static define (or parameter?) instead of "100", we might want to tweak this number.

Line:97, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> spacing

Line:98, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> java variable name plz

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacket.java xxx@xxx.xxx

Line:23, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacket.java -> empty line

Line:95, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacket.java -> remove 1 or 2 lines

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> remove empty line

Line:23, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> add empty line

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> you've added an empty line here, good!

Line:17, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/Command.java xxx@xxx.xxx

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/Command.java -> add empty line below

Line:36, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/Command.java -> add empty line below here too

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java xxx@xxx.xxx

Line:23, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java -> space after ,

add empty line after

Line:27, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java -> put the [] next to the type, makes it clearer it's an array.

Although here too, check if storing it as a List wouldn't be more appropriate

Line:55, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java -> comments

Line:36, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/SessionResponse.java -> Is it worth storing these as a byte array, or could it be converted to String?

Line:117, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/SessionResponse.java -> comments

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/MetadataPacketResponse.java -> ...response? it's not the packet itself

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/MetadataPacketResponse.java xxx@xxx.xxx

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/MetadataPacketResponse.java -> add empty line

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java xxx@xxx.xxx

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java -> some (all?) of these fields could be final and set at the constructor

Line:66, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java -> add comments explaining where this size comes from

Line:70, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java -> this looks more like a serialize() method

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> remove this line

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> see if List isn't more appropriate

Line:44, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> Ctrl+Shift+F this file

Line:63, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> don't save directly, make a copy

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacketReturnCode.java xxx@xxx.xxx

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacketReturnCode.java -> empty line

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacketReturnCode.java -> empty line

Line:610, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> definition on the same line

Line:947, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> minor thing, but in the case where you go inside the if, you could keep a reference to the "new Stream", so you do not need to do a map lookup in that case.

Line:2, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/LTTngViewerCommands.java -> 2014

or 2013, 2014

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/LTTngViewerCommands.java -> TCP

API is defined at... (not really "copied" here, it's a different file/implementation).

BSD-licensed (hyphen)

put the URL on one line

Line:27, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/LTTngViewerCommands.java -> static final

Line:33, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/LTTngViewerCommands.java -> static-final order is fine, but public isn't needed

there's always something isn't there -.-

Line:45, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/StreamResponse.java -> here too, could these be strings?

Line:115, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/StreamResponse.java -> comments

Line:51, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> leave an empty line after

Line:75, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> 4096 should be a static define

Line:118, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> 8 should be a static define. AttachSessionResponse.size() maybe?

Line:132, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> when calling toArray(), you should pass the real size of the array (new StreamResponse[temp.size()]), to avoid creating an extra array. That's how I understand the Javadoc anyway.

But in any case here, just passing the array would probably be simpler (see previous comment in AttachSessionResponse).

Line:150, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> where does this 12 come from? static define maybe?

Line:155, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> potentially unsafe cast. You can use Long.valueOf(x).intValue(), or check it yourself manually.

same at the line below

Line:157, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> this variable is not needed, return new String(...)

Line:490, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfTrace.java -> wut

Line:13, lttng/org.eclipse.linuxtools.lttng2.core/META-INF/MANIFEST.MF -> Ideally it should not access ctf.core directly. Can't it go through tmf.ctfadaptor? (eventually, tmf.ctf plugin). Maybe more things should be exposed in there?

Line:17, lttng/org.eclipse.linuxtools.lttng2.core/META-INF/MANIFEST.MF -> that's a bit long of a name ;)  "live" and "connector" don't bring anything, lttng2.core.relayd would be enough namespacing

Line:19, lttng/org.eclipse.linuxtools.lttng2.core/META-INF/MANIFEST.MF -> all packages should be marked x-internal, or exposed to tests only

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayCommand.java xxx@xxx.xxx

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayCommand.java -> add empty line

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayCommand.java -> remove public

Also, looking at the implementation of these methods, maybe this should be called serialize() instead. Then we'd have to see if it'd be worth having this extend Serializable too.

Line:2, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> 2014

or if there is really 2013 contents in here, it should be "2013, 2014"

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> remove this empty line

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> be consistent with the name class names, either Relayd or RelayD. TBH, I prefer Relayd

Line:41, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> If the index of the list doesn't mean anything, only return an Iterable.

No need for "public" in interface methods. Applies to other methods below too.

Line:116, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> Iterable?

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IFixedSize.java xxx@xxx.xxx

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IFixedSize.java -> add empty line

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IFixedSize.java -> remove public

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadataReturnCode.java xxx@xxx.xxx

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadataReturnCode.java -> space before {

empty line after

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadataReturnCode.java -> empty line

-------------------------------------
author: Ivy Mitchell
date: 2014-04-21 13:27:50.000000000

Patch Set 7:

(84 comments)

Line:112, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConsumer.java -> please open a bug better describing what you want to see. :)

Line:17, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachReturnCode.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IBaseCommand.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> Done

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> Done

Line:71, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionResponse.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetNextIndex.java -> Done

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectionType.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectionType.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayResponse.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadata.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionResponse.java -> Done

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionResponse.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> Done

Line:142, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IndexResponse.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> Done

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> right now it is, when it's not, we will update/

Line:38, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> Done

Line:97, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> Done

Line:104, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> Done

Line:108, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ConnectResponse.java -> Done

Line:45, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConnectorFactory.java -> Done

Line:50, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConnectorFactory.java -> Done

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_NOTSUPPORTED.java -> Done

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_NOTSUPPORTED.java -> Done

Line:35, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_NOTSUPPORTED.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:11, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:44, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:47, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:53, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:97, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:98, lttng/org.eclipse.linuxtools.lttng2.core.tests/src/org/eclipse/linuxtools/lttng2/core/tests/live/relayd/connector/LTTngRelayD24Test.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacket.java -> Done

Line:23, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacket.java -> Done

Line:95, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacket.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> Done

Line:23, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> Done

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> Done

Line:17, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/Command.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/Command.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java -> Done

Line:23, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java -> Done

Line:27, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/ListSessionsResponse.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/MetadataPacketResponse.java -> Done

Line:21, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/MetadataPacketResponse.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/MetadataPacketResponse.java -> Done

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java -> Done

Line:66, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java -> Done

Line:70, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/AttachSessionRequest.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> Done

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> Done

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> Done

Line:44, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> Done

Line:63, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/NewStreamsResponse.java -> Done

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacketReturnCode.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacketReturnCode.java -> Done

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetPacketReturnCode.java -> Done

Line:51, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:51, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:75, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:118, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:132, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:150, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:155, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:157, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/impl/LttngRelayDConnector_2_4.java -> Done

Line:13, lttng/org.eclipse.linuxtools.lttng2.core/META-INF/MANIFEST.MF -> To be debated. Consider we receiver metadata

Line:19, lttng/org.eclipse.linuxtools.lttng2.core/META-INF/MANIFEST.MF -> the commands are part of the API.

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayCommand.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayCommand.java -> Done

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IRelayCommand.java -> Done

Line:30, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> Done

Line:32, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> Done

Line:41, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> iterable would mean I lose Immutable list, do we want that?

Line:116, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/ILttngRelaydConnector.java -> Done

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IFixedSize.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IFixedSize.java -> Done

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/IFixedSize.java -> Done

Line:18, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadataReturnCode.java -> Done

Line:20, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadataReturnCode.java -> Done

Line:26, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/GetMetadataReturnCode.java -> Done

-------------------------------------
author: Braxton Mccarthy
date: 2014-04-22 20:36:16.000000000

Patch Set 7:

(2 comments)

Line:112, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/LttngRelaydConsumer.java -> sure, I'll prototype later ;)

Line:28, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/live/relayd/connector/lttngviewerCommands/CreateSessionReturnCode.java -> Done? There was nothing to do! Are you reading this, or just mind-numbingly clicking Reply 'Done'? xD

-------------------------------------
