DESCRIPTION

lttng: Add Lttng relayd connector

This allows connections to the lttng session daemon so that live trace
reading can work.

(rebased on lttng: Rename lttng2 feature/plugins to lttng2.control)

Conflicts:
	Everything

Change-Id: Ida7f76f09d3f01a25b67cc552cb5869dc5e4c3a4
Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-05-01 03:51:05.000000000

Patch Set 18:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6781/

-------------------------------------
author: Brenden Conley
date: 2014-05-01 04:48:52.000000000

Patch Set 18: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6781/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-05-01 20:35:42.000000000

Patch Set 18: Code-Review-1

(6 comments)

Some comments from PS16 were not addressed. I put them up again, so now they should stick to the new file names/paths.

Line:92, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/relayd/lttngviewerCommands/AttachSessionResponse.java -> private static final field (saves a function call)

Line:55, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/relayd/lttngviewerCommands/ListSessionsResponse.java -> use an ImmutableList.Builder

Line:84, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/relayd/lttngviewerCommands/TracePacketResponse.java -> The array should not be exposed directly (caller can modify the elements in it). Copy before returning, or, guess what!, ImmutableList<Byte> (although that one might be a bit less interesting because you'd have to convert byte -> Byte).

Line:88, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/relayd/lttngviewerCommands/TracePacketResponse.java -> private static final field

Line:76, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/relayd/lttngviewerCommands/MetadataPacketResponse.java -> private static final fields

Line:91, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/relayd/lttngviewerCommands/NewStreamsResponse.java -> private static final field

-------------------------------------
