DESCRIPTION

lttng: Add Lttng relayd connector

This allows connections to the lttng session daemon so that live trace
reading can work.

Change-Id: Ida7f76f09d3f01a25b67cc552cb5869dc5e4c3a4
Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-04-23 22:03:19.000000000

Uploaded patch set 16.

-------------------------------------
author: Brenden Conley
date: 2014-04-24 04:45:42.000000000

Patch Set 16:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6610/

-------------------------------------
author: Brenden Conley
date: 2014-04-24 05:22:18.000000000

Patch Set 16: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6610/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-04-24 14:03:13.000000000

Patch Set 16: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6629/

-------------------------------------
author: Brenden Conley
date: 2014-04-24 14:58:05.000000000

Patch Set 16: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6629/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-04-24 22:52:05.000000000

Topic set to Live trace reading

-------------------------------------
author: Ivy Mitchell
date: 2014-04-30 20:03:00.000000000

Patch Set 16: Code-Review-1

pre-emptive rebase

-------------------------------------
author: Braxton Mccarthy
date: 2014-04-30 20:19:24.000000000

Patch Set 16: Code-Review-1

(9 comments)

A couple comments on the new version. Getting there ;)

Also yes please rebase on the rename patch.

Line:92, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/AttachSessionResponse.java -> If this is constant for all instances, it could be a private static field

Line:19, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/LttngViewerCommands.java -> This will not pass Java 8 doclint ;)

Line:74, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/impl/LttngRelaydConnector_Unsupported.java -> The close() should be a no-op, because it will get called automatically.

Line:76, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/MetadataPacketResponse.java -> if it's the same for all instances, it can be private static field

Line:39, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/ListSessionsResponse.java -> In cases where the field is kept as an ImmutableCollection, I'd use the declaration type ImmutableList and so on. It kind of contradicts what we normally do, but you'd get warnings if you try to do .put() etc. from within the class. Up to you.

Line:59, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/ListSessionsResponse.java -> Use a ImmutableList.Builder

Line:90, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/NewStreamsResponse.java -> private static field

Line:87, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/TracePacketResponse.java -> private static field

Line:87, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/relayd/lttngviewerCommands/TracePacketResponse.java -> private static field

-------------------------------------
