DESCRIPTION

TMF: XML Explorer

- Integration of the XMl editors and tools
- Addition of the ability to create and edit an XML file
- Addition of the xml schema definition to the XSD catalog
- Addition of the XML explorer view

Change-Id: Ic312719bd93549d21caa61113a759cbd681ee6aa
Signed-off-by: Branden Mercer xxx@xxx.xxx


COMMENTS

author: Branden Mercer
date: 2014-04-01 00:50:35.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-04-01 00:50:41.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6170/

-------------------------------------
author: Brenden Conley
date: 2014-04-01 01:23:00.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6170/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-04-01 14:18:25.000000000

Patch Set 2: Code-Review-1

(4 comments)

Line:175, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/internal/tmf/analysis/xml/ui/Activator.java -> Descripter -> Descriptor

Line:90, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/plugin.xml -> I'm not sure the ../ will always work. Did you try installing the plugin into an Eclipse installation and see if it still works?

Line:100, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/plugin.xml -> The id should probably end with something else then "view1". It should be consistent with the id you defined in the XMLExplorerView class, so it should be org.eclipse.linuxtools.tmf.ui.views.xmlExplorer

Line:63, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/views/xmlExplorer/XMLExplorerView.java -> This doesn't match the id in the plugin.xml

-------------------------------------
