DESCRIPTION

TMF: Implementation of UstMemoryAnalysisModule requirements

The events needed by the analysis are added as requirements. We also add the
information that the libc with probes should be loaded prior to starting the
trace session.

Change-Id: Idcfb13d7ae43bb73f6631c12f4eeb52fe74976d5
Signed-off-by: Bailey Galloway xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-05-01 06:24:10.000000000

Patch Set 13:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6783/

-------------------------------------
author: Brenden Conley
date: 2014-05-01 07:07:05.000000000

Patch Set 13: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6783/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-05-01 21:09:30.000000000

Patch Set 13: Code-Review-1

(3 comments)

Line:2, lttng/org.eclipse.linuxtools.lttng2.ust.core/src/org/eclipse/linuxtools/lttng2/ust/core/analysis/memory/messages.properties -> This path might not always be the real one. Perhaps instead say

  LD_PRELOAD=/path/to/liblttng-ust-libc-wrapper.so ./myProgram

Up to you.

Line:54, lttng/org.eclipse.linuxtools.lttng2.ust.core/src/org/eclipse/linuxtools/lttng2/ust/core/analysis/memory/UstMemoryAnalysisModule.java -> should static final (with name in ALL_CAPS)

Same as on the other patch, the whole content of the constructor should be a static {} block, and the constructor declaration can be removed.

Line:84, lttng/org.eclipse.linuxtools.lttng2.ust.core.tests/src/org/eclipse/linuxtools/lttng2/ust/core/tests/analysis/memory/UstMemoryAnalysisModuleTest.java -> ImmutableSet (contains() is faster)

-------------------------------------
