DESCRIPTION

TMF: Implementation of LttngKernelAnalysis requirements

The events needed by the analysis are added as requirements.

Change-Id: I4f8930815d8c3a088986ada4dfffb9b737d25af0
Signed-off-by: Bailey Galloway xxx@xxx.xxx
Signed-off-by: Keshawn Lopez xxx@xxx.xxx


COMMENTS

author: Bailey Galloway
date: 2014-05-02 14:11:21.000000000

Uploaded patch set 15.

-------------------------------------
author: Brenden Conley
date: 2014-05-02 14:11:27.000000000

Patch Set 15:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6812/

-------------------------------------
author: Brenden Conley
date: 2014-05-02 15:09:23.000000000

Patch Set 15: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6812/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-05-02 17:00:28.000000000

Patch Set 15: Code-Review+1

Just a note about static initializers (both {} blocks and static declarations). Be careful not to use classes that depend, directly or indirectly, on that class itself. At run-time, the class loader would blow up.

In the case here it looks fine, just something to keep in mind.

-------------------------------------
author: Annalise Jimenez
date: 2014-05-02 19:20:30.000000000

Patch Set 15: Code-Review-1

(2 comments)

Small comments, I'll upload a patch later

Line:56, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> Since the analysis may be used by other tests, it should be disposed of in the tearDown block

Line:100, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> Assert not necessary since the elements are counted below

-------------------------------------
