DESCRIPTION

TMF: Implementation of LttngKernelAnalysis requirements

The events needed by the analysis are added as requirements.

Change-Id: I4f8930815d8c3a088986ada4dfffb9b737d25af0
Signed-off-by: Bailey Galloway xxx@xxx.xxx
Signed-off-by: Keshawn Lopez xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-05-01 05:47:29.000000000

Patch Set 14:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6782/

-------------------------------------
author: Brenden Conley
date: 2014-05-01 06:31:20.000000000

Patch Set 14: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6782/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-05-01 20:54:15.000000000

Patch Set 14: Code-Review-1

(4 comments)

Line:63, lttng/org.eclipse.linuxtools.lttng2.kernel.core/src/org/eclipse/linuxtools/lttng2/kernel/core/analysis/LttngKernelAnalysisModule.java -> The comment doesn't match the code (list vs Set)

Static variables should have a name in ALL_CAPS.

Could be final too.

Line:75, lttng/org.eclipse.linuxtools.lttng2.kernel.core/src/org/eclipse/linuxtools/lttng2/kernel/core/analysis/LttngKernelAnalysisModule.java -> All this should be in a static initializer block. Else you recreate the class field every time you make a new object.

You can remove the constructor altogether after (it will use the super-class's default constructor automatically).

Line:57, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> CtfTmfTrace.close() shoud be preferred now (we're slowly moving AutoCloseable up to TmfTrace....), but they both do the same thing, so it's fine. Just something to keep in mind for future code.

Line:127, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> Since you only do .contains, a Set would be better here. Doesn't really matter in the test code (but it would in runtime code!!)

-------------------------------------
