DESCRIPTION

TMF: Add some utility methods to XmlUtils

Change-Id: Ic81b17b6d89342fb41cd9f5898830ef20e8c1b93
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2014-03-13 14:10:00.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-03-13 14:53:46.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5916/

-------------------------------------
author: Brenden Conley
date: 2014-03-13 15:48:26.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5916/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-03-13 21:56:03.000000000

Patch Set 2:

(2 comments)

Line:211, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/XmlUtils.java -> Would it make sense to xxx@xxx.xxx to filePath as well?

Line:117, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java -> That weird formatting from JDT :/ I think if you xxx@xxx.xxx before, it does the same and it will format on one line correctly.

-------------------------------------
author: Annalise Jimenez
date: 2014-03-14 19:11:27.000000000

Patch Set 2:

(2 comments)

Line:211, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/XmlUtils.java -> It would if java's toString method would xxx@xxx.xxx This method is sometimes called like this: fFilePath.makeAbsolute().toString()

I prefer to make a null check in this method than force all callers to add their own null checks. They have to null check the return value anyway.

Line:117, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java -> Actually, the default formatting puts xxx@xxx.xxx on a separate line anyway. oh well!

-------------------------------------
