DESCRIPTION

tmf: add swtbot tests for custom text parser

This test adds a complex parser then validates the generated XML.
Then it removed the parser and re-validates the xml.

Change-Id: I3f93cb8ff3e45db63b6badf9aa5793c7ff3f4807
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-03-04 15:43:51.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-03-04 15:43:56.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5791/

-------------------------------------
author: Kaeden Tapia
date: 2014-03-04 19:56:26.000000000

Patch Set 3: Code-Review-1

(4 comments)

Line:79, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> I think we should move this check to the Util class. SWTBotUtil.checkNonUIThread?

Line:86, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> the timeout looks pretty low compared to the kernel test (300 seconds)

Line:190, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> was that println for debug purposes?

Line:206, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> This looks like the same code as above, can it be extracted to a common method?

-------------------------------------
author: Ivy Mitchell
date: 2014-03-04 20:15:09.000000000

Patch Set 3:

(3 comments)

Line:86, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> kernel is 30 seconds, no? we also are not reading a full trace, we're just spamming menus.

Line:190, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> yes, d'oh!

Line:206, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> Absotitvely posilutely

-------------------------------------
author: Kaeden Tapia
date: 2014-03-04 20:33:17.000000000

Patch Set 3:

(1 comment)

Line:86, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> OK, 20 seconds seems fine.

-------------------------------------
author: Ivy Mitchell
date: 2014-03-04 22:33:51.000000000

Patch Set 3:

(1 comment)

Line:86, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> It turns out it's 300.. IMO this is too long.

-------------------------------------
