DESCRIPTION

tmf: replace find() with matches() in CustomTxtTrace.java

This should provide a nice performance boost and make the regexes less
ambiguous.

With matches, the reader will match per line instead of searching for a
match. this can save up to an order of magnitude in reading.

Change-Id: I267426a9f2ab672590e35edafef2913ac32ac8f2
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-02-27 20:17:13.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-02-27 20:52:27.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5728/

-------------------------------------
author: Brenden Conley
date: 2014-02-27 21:34:59.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5728/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-03-06 14:50:00.000000000

Patch Set 2: Verified+1 IP-Clean+1 Code-Review+1

It looks good for me. However, I'd like Patrick to approve.

-------------------------------------
author: Ivy Mitchell
date: 2014-03-06 17:56:20.000000000

Patch Set 2:

agreed

-------------------------------------
author: Kaeden Tapia
date: 2014-03-12 21:38:29.000000000

Patch Set 2:

Patrick could you double check this patch?

-------------------------------------
author: Luciana Barry
date: 2014-03-13 15:40:21.000000000

Patch Set 2: Code-Review+1 IP-Clean+1

(1 comment)

Line:166, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/wizards/CustomTxtParserInputWizardPage.java -> There are tabs before a xxx@xxx.xxx annotations in this file. You might want to replace them with spaces at the same time. Or not.

-------------------------------------
author: Ivy Mitchell
date: 2014-03-13 19:53:54.000000000

Patch Set 2:

(1 comment)

Line:166, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/wizards/CustomTxtParserInputWizardPage.java -> I will do it later

-------------------------------------
author: Ivy Mitchell
date: 2014-03-14 15:48:04.000000000

Patch Set 2: Code-Review+2

-------------------------------------
author: Gerrit Code Review
date: 2014-03-14 15:48:05.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
author: Gerrit Code Review
date: 2014-03-14 15:48:22.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
