DESCRIPTION

Systemtap: Forbid negative pie chart slices.

Change-Id: I19433e720e0113f9ab6d99f5f8f0e26d859aa1cb
Signed-off-by: Landon Wilkins xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-02-22 00:56:03.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5632/

-------------------------------------
author: Brenden Conley
date: 2014-02-22 01:34:57.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5632/ : SUCCESS

-------------------------------------
author: Kamila Nguyen
date: 2014-02-26 15:33:42.000000000

Patch Set 1:

(1 comment)

Line:70, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/charts/PieChartBuilder.java -> Hmm.. How do we end up with negative slices in the first place ?

-------------------------------------
author: Landon Wilkins
date: 2014-02-26 15:45:17.000000000

Patch Set 1:

(1 comment)

Line:70, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/charts/PieChartBuilder.java -> You can parse negative numbers from a script with (-?\d+), and can display them in a Pie Chart in the same way you would display any kind of script output in any kind of chart.

Even if a data type isn't appropriate for a chart (like negative values in Pie Charts, or String values in Line/Scatter/Area charts), values won't be filtered out unless it's done manually, so I'm doing it here in the same way it was done for some other charts.

-------------------------------------
author: Kamila Nguyen
date: 2014-02-26 16:15:36.000000000

Patch Set 1: Verified+1 Code-Review+2 IP-Clean+1

(1 comment)

Line:70, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/charts/PieChartBuilder.java -> I see.

-------------------------------------
