DESCRIPTION

TMF: [WIP] Add analysis requirement to generate traces from an analysis

Change-Id: I764291e0ca5281550a16d61a9aa8dbf5ca05d390
Signed-off-by: Keshawn Lopez xxx@xxx.xxx
Signed-off-by: Bailey Galloway xxx@xxx.xxx
Signed-off-by: Keshawn Lopez xxx@xxx.xxx


COMMENTS

author: Keshawn Lopez
date: 2014-03-27 15:17:05.000000000

Uploaded patch set 6.

-------------------------------------
author: Keshawn Lopez
date: 2014-03-27 15:19:25.000000000

Patch Set 6:

The getValidTraceType and getAnalysisRequirements methods for the classes implementing IAnalysisModuleHelper will be implemented in subsequent patches.

-------------------------------------
author: Brenden Conley
date: 2014-03-27 15:44:40.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6120/

-------------------------------------
author: Brenden Conley
date: 2014-03-27 16:26:05.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6120/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-04-04 19:11:47.000000000

Patch Set 6:

(6 comments)

review during push.

Line:12, /COMMIT_MSG -> you only need to sign off once.

Line:120, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfAnalysisModuleHelperXml.java -> could this be ITmfTrace?

Line:23, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/analysis/TmfAnalysisRequirement.java -> peered or paired? level or priority?

Line:34, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/analysis/TmfAnalysisRequirement.java -> useful information (no s)

Line:35, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/analysis/TmfAnalysisRequirement.java -> Priority-less information can be added?

Line:55, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/analysis/TmfAnalysisRequirement.java -> Could there be a forbidden value?
If the trace contains value A, it is not a valid trace to run a said analysis?

-------------------------------------
author: Gerrit Code Review
date: 2014-04-15 22:10:24.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
