DESCRIPTION

tmf: Correctly export xychart packages in tmf.ui

Some packages were still marked as internal when they weren't supposed
to be. This was giving some warnings, because some classes in one of
those was being used in API methods.

Change-Id: I93f3e10617e8a061a686313926434e163aa6ce81
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-02-15 01:43:16.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5512/

-------------------------------------
author: Brenden Conley
date: 2014-02-15 02:04:16.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5512/ : FAILURE

-------------------------------------
author: Kaeden Tapia
date: 2014-02-15 04:22:05.000000000

Patch Set 1:

I thought Meredith Scott made them internal on purpose? Maybe I dreamt that.

-------------------------------------
author: Ricky Reeves
date: 2014-02-17 11:52:27.000000000

Patch Set 1:

I put them internal till the APIs can be seen as stable. Right now, I think, they are not. Things are still being moved around (see https://git.eclipse.org/r/#/c/22029/).

-------------------------------------
author: Braxton Mccarthy
date: 2014-02-17 18:20:46.000000000

Patch Set 1:

If they are to be internal, then there should be "internal" in the package name. That's what the guidelines say. Perhaps this is what we should do instead?

The danger of keeping such a half-way situation is that we forget about it, and it ends up being shipped in Luna.

-------------------------------------
author: Kaeden Tapia
date: 2014-02-18 15:52:19.000000000

Patch Set 1:

Geneviève, do you foresee a lot of changes in the XY charts on your end?

-------------------------------------
author: Annalise Jimenez
date: 2014-02-18 17:23:08.000000000

Patch Set 1:

Of course there will be changes to the API :) but I don't foresee anything major though... I'm using it in a couple of view and it makes sense.

I have no strong opinion on this. Just that whether or not it's internal, we ARE going to use it and have xxx@xxx.xxx on the class using it...

-------------------------------------
author: Kaeden Tapia
date: 2014-02-18 19:14:25.000000000

Patch Set 1:

OK. It sounds like it should stay internal for now. In that case, I think the packages should be named accordingly. If we change our mind before the Luna release, it won't be a hard change anyway.

-------------------------------------
