DESCRIPTION

tmf: Add default custom Xml partsers

Same as custom text. Also stored in $ECLIPSE_HOME/ but in custom_xml_default_parsers.xml

Change-Id: I77591b0224afdc9f95bca602563d9e8164218f51
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-02-14 00:06:13.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5483/

-------------------------------------
author: Brenden Conley
date: 2014-02-14 00:46:44.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5483/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-02-17 13:34:44.000000000

Patch Set 1:

(3 comments)

See inline comments.

Also, there are the same problems as review of patch set 4 of https://git.eclipse.org/r/#/c/21923/.

Line:9, /COMMIT_MSG -> Please add a proper description what the patch does instead of "Same as custom text".

Line:65, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> To be consistent with the custom text parser use custom_x
ml_default_parsers.xml as default parser

Line:72, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> The default definition file should under a sub-directory of ECLIPSE_HOME

-------------------------------------
author: Ricky Reeves
date: 2014-02-17 13:35:01.000000000

Patch Set 1: Code-Review-1

See comments before

-------------------------------------
author: Ivy Mitchell
date: 2014-02-17 14:48:53.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:7, /COMMIT_MSG -> D'oh!

-------------------------------------
