DESCRIPTION

Systemtap: Make updates to toolbar buttons.

1) Group together all Systemtap-related workbench toolbar
buttons in their own toolbar.

2) Remove unused components from ui.ide/plugin.xml.

3) Rework "Import Tapset" to use a Command rather than a
(deprecated) Action Set.

4) Change the "Import Tapset" and "Import Data Set" commands
to be enabled only when in the Systemtap IDE perspective.

Change-Id: I19c55142fa5e0f433fb36b0f2298cb3ff7a2ec54
Signed-off-by: Landon Wilkins xxx@xxx.xxx


COMMENTS

author: Erick Ross
date: 2014-02-13 09:20:45.000000000

Patch Set 3:

(3 comments)

I like the new look a lot. Just some minor fixes needed.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/actions/ImportTapsetHandler.java -> Missing license header!

Line:28, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/actions/ImportTapsetHandler.java -> !path.isEmpty() is better than path.length > 0 - both as readability and speed

Line:56, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/actions/ImportTapsetHandler.java -> Please no trailing whitespaces.

-------------------------------------
author: Brenden Conley
date: 2014-02-13 10:10:53.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5459/

-------------------------------------
author: Brenden Conley
date: 2014-02-13 10:56:41.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5459/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2014-02-14 10:13:17.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
