DESCRIPTION

TMF: Add unit tests for XML state providers

Change-Id: I219ea02913f1d9505e8bc894523e1a73722b5cd5
Signed-off-by: Aryana Jones xxx@xxx.xxx
Signed-off-by: Ayanna Reed xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-02-03 21:55:34.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5296/

-------------------------------------
author: Brenden Conley
date: 2014-02-03 22:50:20.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5296/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-02-18 19:40:11.000000000

Patch Set 1: Code-Review-1

(7 comments)

small comments

Line:78, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java -> Don't this line and the block you added do EXACTLY the same thing?

Line:74, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderTest.java -> same comments as previous file

Line:88, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderTest.java -> don't wrap

Line:128, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderTest.java -> that's a quite basic test ;)

Shouldn't it look at 2-3 of the entries to make sure they match what we expect. To ensure we don't read corrupted data from the XML.

Line:61, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderModuleTest.java -> don't wrap at .

Line:63, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderModuleTest.java -> can define/declare on same line

Line:135, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderModuleTest.java -> You should do the assume at the start of the test, and skip the whole thing if it's not present.

-------------------------------------
author: Annalise Jimenez
date: 2014-02-19 16:44:34.000000000

Patch Set 1:

(2 comments)

Line:78, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java -> Yeah, but the other fails telling exactly what the error was, so for debugging purposes it's great! But I forgot to bring it back to original before pushing ;-)

Line:128, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/stateprovider/StateProviderTest.java -> I guess I could add the same tests as the LTTng kernel state system. But I was thinking to wait for the XmlCustomHandMadeTrace to make traces that will exactly test a few well-thought scenarios and bonify these unit tests. But if you wish for something right now, I can add a few cases.

-------------------------------------
