DESCRIPTION

tmf: Fix AOOB exception in Import Trace Packafe

The exception would happen when canceling the overwrite prompt
(by clicking on the X in the dialog corner).

Change-Id: I070806b0221ef15c68c7973d777ff66487f57f78
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-01-31 23:39:06.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5284/

-------------------------------------
author: Brenden Conley
date: 2014-02-01 00:26:10.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5284/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-02-03 15:30:50.000000000

Patch Set 1:

(1 comment)

Line:353, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/wizards/tracepkg/importexport/ImportTracePackageWizardPage.java -> would it be better to make this compare to actual return values? I understand it should give : IDialogConstants, no?

-------------------------------------
author: Kaeden Tapia
date: 2014-02-03 15:58:52.000000000

Patch Set 1:

(1 comment)

Line:353, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/wizards/tracepkg/importexport/ImportTracePackageWizardPage.java -> Unfortunately, for this case there is no constant. The return code is an index to a button in the dialog but the 'X' button in the window corner is not considered a button therefore it returns -1. I documented this better.

-------------------------------------
