DESCRIPTION

tmf: Move TmfTraceType and custom parsers to tmf.core

This required splitting the UI-specific functionality in
TmfTraceType into a new TmfTraceTypeUiUtils, which remains
in the tmf.ui plugin.

Change-Id: I717cb1676fec530efa99be1056be4010b6ca8bd7
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-01-31 00:14:25.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5268/

-------------------------------------
author: Brenden Conley
date: 2014-01-31 01:06:10.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5268/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-01-31 21:12:51.000000000

Patch Set 1: Code-Review-1 IP-Clean-1

(15 comments)

Some minor fixes, this is really good though!

Line:1, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> Copyright header

Line:34, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> more javadoc please

Line:163, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> Proper capitalization please

Line:173, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> Should this be validateTraces?

Line:179, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> This javadoc is beautiful

Line:248, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> this member is nice. I can see it often being reused.

Line:386, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> Moooooooolti-catch

Line:513, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> multicatch

Line:576, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> multicatch

Line:737, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> multicatch

Line:642, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomTxtTraceDefinition.java -> multi-catch

Line:706, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomTxtTraceDefinition.java -> leeloo dallas: multi-catch

Line:859, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomTxtTraceDefinition.java -> Gandalf: You shall not... 
Leeloo: Multicatch!
Gandalf: :(

Line:223, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/wizards/tracepkg/importexport/TracePackageImportOperation.java -> blank line

Line:310, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTrace.java -> multi-catch?

-------------------------------------
author: Braxton Mccarthy
date: 2014-01-31 21:23:09.000000000

Patch Set 1:

(4 comments)

Why IP-unclean??

Regarding moolti-catch: I'd rather fix those separately. There are other simplifications that could be done to them too (e.g., SAXException is a subclass of ParserException, things like that). This patch is more about the TmfTraceType split, and minimally affecting the other files.

I will add copyright header soonish.

Line:1, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> oh snap, good point. I guess "I'll add the copyright headers at the end" is a recipe for forgetting it completely.

Line:34, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> It's right next to the copyright header

Line:179, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceTypeUIUtils.java -> I just cut-n-pasted what was in TmfTraceType >.>

Line:223, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/wizards/tracepkg/importexport/TracePackageImportOperation.java -> huh?

-------------------------------------
author: Braxton Mccarthy
date: 2014-01-31 21:23:39.000000000

Patch Set 1:

> Why IP-unclean?

> I will add copyright header

I kind of answered my own question.

-------------------------------------
