DESCRIPTION

ctf: Metadata add support for incremental reading

Metadata now supports parseText and parseTextFragment
ParseText is needed to parse the initial trace
ParseFragment is needed to avoid reparsing in full the trace

Change-Id: If1857e0b5bb07e5a97cb635bcd7b960b9037f2c7
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-01-21 15:54:27.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5120/

-------------------------------------
author: Brenden Conley
date: 2014-01-21 16:31:04.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5120/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-01-29 16:58:40.000000000

Patch Set 1: Code-Review-1

(9 comments)

File Comment: lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/Metadata.java -> This file has a bunch xxx@xxx.xxx missing

Line:149, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/Metadata.java -> Does this FileReader need to be closed?

Line:164, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/Metadata.java -> This only gets assigned once then returned the line bellow. It think it could be removed and just inline the return

Line:190, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/Metadata.java -> The javadoc should just mention CTFReaderException

Line:218, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/Metadata.java -> The javadoc should just mention CTFReaderException

Line:165, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/trace/MetadataTest.java -> We should probably keep setUp xxx@xxx.xxx and make another method "init". The assumeTrue should probably stay in the setUp

Line:93, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/metadata/IOStructGen.java -> Minor but remove this extra line if you end up updating this patch.

Line:302, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/metadata/IOStructGen.java -> "*to* parse this chunk" ?

Line:194, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java xxx@xxx.xxx missing

-------------------------------------
