DESCRIPTION

TMF: Add possibility to select experiment type from UI

Modified trace type contribution item to element contribution item to add
experiment types to the list and show only trace or experiment type depending
on the selected element. Add the menu items for the experiment type selection.

Change-Id: Id566ce7c30a89d5371c2c311d7d96c1f065bf7fa
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2014-02-26 15:33:24.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-02-26 17:50:42.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5704/

-------------------------------------
author: Brenden Conley
date: 2014-02-26 18:38:58.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5704/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-02-28 20:42:25.000000000

Patch Set 3: Code-Review-1

(6 comments)

Line:787, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> remove whitespace since you need to update it.

Line:1011, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> this command is not used anywhere

Line:1015, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> not defined in plugin.properties file

Line:1020, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> not defined in plugin.properties file

Line:1025, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> not defined in plugin.properties file

Line:224, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/SelectElementTypeContributionItem.java -> This code up to heare is a partly copy of  getTraceContributionItems() only TmfTraceType.EXPERIMENT_ELEM check is different, right? It would be good to have a method for it the common code and call it from getTraceContributionItems() and getTraceContributionItems()

-------------------------------------
