DESCRIPTION

[TMF] change access modifiers for fields used in TimeGraphControl.drawState

TimeGraphControl.drawState() is protected, and therefore can be overridden.
Unfortunately, this method uses two private fields: fEventColorMap and
fTimeGraphProvider. Therefore, in order to be able to override this method,
these two fields must be at least protected.

Change-Id: Ia82d422f33b8a8c205b761104340b4d293fae33a
Signed-off-by: Bryce Kline xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-01-09 12:02:42.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4955/

-------------------------------------
author: Brenden Conley
date: 2014-01-09 12:33:34.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4955/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-01-10 20:07:31.000000000

Patch Set 1: Code-Review-1

(2 comments)

-1 for the API errors

Could also be fixed by adding protected getters (and setters?) instead. Would it be a better solution?

Line:111, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphControl.java -> xxx@xxx.xxx tag

Line:131, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphControl.java -> Missing Javadoc
xxx@xxx.xxx tag

-------------------------------------
author: Braxton Mccarthy
date: 2014-01-10 21:30:23.000000000

Patch Set 1:

Protected getters/setters should be used instead of exposing the field directly, definitely. But then those will xxx@xxx.xxx annotations too ;)

-------------------------------------
