DESCRIPTION

tmf: Switch tmf.ui to Java 7 + fix warnings

Change-Id: I1fd5700aa5f37e6c279752374ab6c1bcf2633d20
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-12-18 01:07:02.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4740/

-------------------------------------
author: Brenden Conley
date: 2013-12-18 02:00:33.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4740/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2013-12-18 22:14:30.000000000

Patch Set 1: Code-Review+1 IP-Clean+1

(9 comments)

Some minor questions here

Line:631, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/wizards/CustomTxtParserInputWizardPage.java -> I know this is just a reformat, but this needs comments.

Line:34, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/timechart/TimeChartDecorationProvider.java -> one tab

Line:519, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtTraceDefinition.java -> once again, not convinced on the one liner try with resources where it may degrade readability.

Line:848, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtTraceDefinition.java -> ^ see above

Line:83, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/rawviewer/TmfRawEventViewer.java -> tabs

Line:380, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlTraceDefinition.java -> not sold on one liners

Line:727, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlTraceDefinition.java -> ^_^ same (double arrow)

Line:81, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/commands/ExportToTextJob.java -> nice improvement

Line:57, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/colors/ColorSettingsManager.java -> tabs for another patch?

-------------------------------------
author: Braxton Mccarthy
date: 2013-12-19 01:03:34.000000000

Patch Set 1: Code-Review+2

(2 comments)

Line:519, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtTraceDefinition.java -> How does it degrade readability? We actually remove one line of "code" (write.close() becomes a "}")

This is a weird case here anyway, because we are already in a try/catch that catches IOException. Normally this try clause would have its own catch.

Line:57, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/colors/ColorSettingsManager.java -> ideally

-------------------------------------
