DESCRIPTION

TMF: Add XML state provider analysis module and XML utilities

This patch adds an analysis module for an XML-defined state system. It does not
actually build the state system, the details will come in another patch.

It also contains the XML schema definition and the methods to read an XML file
and validate it.

Change-Id: I2a3d322f96742d995912700d223e2ecb9e07d8f5
Signed-off-by: Aryana Jones xxx@xxx.xxx
Signed-off-by: Ayanna Reed xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2014-01-13 15:58:06.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-01-13 16:03:16.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5003/

-------------------------------------
author: Brenden Conley
date: 2014-01-13 16:43:47.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/5003/ : SUCCESS

-------------------------------------
author: Annalise Jimenez
date: 2014-01-13 17:50:50.000000000

Patch Set 3: Code-Review-1

(3 comments)

I corrected a few things, but Florian, I have a question about XmlAbstractProvider vs XmlStateProvider (see below). I'll wait for your answer before pushing again.

Line:84, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/XmlUtils.java -> Use NLS.bind instead

Line:2, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/plugin.properties -> ah non, ce fichier, c'était bien 2013...

Line:40, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/stateprovider/XmlAbstractProvider.java -> Florian, why do you need an abstract state provider? Is it because you expect some other way of expressing a state system?

Could this class be merged with the XmlStateProvider?

-------------------------------------
author: Ayanna Reed
date: 2014-01-13 18:05:35.000000000

Patch Set 3:

(1 comment)

Answer

Line:40, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/stateprovider/XmlAbstractProvider.java -> We can merge it together. The abstract class exists because I use it for the filter. At the beginning, I tkink that the filter must also be a state provider, but with the new progress in the state system query, I thinks that it's better to use directly the existing state system. So the abstract is no necessary anymore.

-------------------------------------
author: Annalise Jimenez
date: 2014-01-13 18:42:47.000000000

Patch Set 3:

(1 comment)

Line:40, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/stateprovider/XmlAbstractProvider.java -> OK then, I'll merge them together from this patch onward.

-------------------------------------
