DESCRIPTION

ctf: better enum and variant verification

Check if enums are valid integers
Check if variants are not using unspecified tags
Check for variant tags recursively
Check for out of range variants
Check for non-intersection between variant and tag

Change-Id: Idd6a98673d8bb3b0a7a1649893a2e21f230a1bcc
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2013-12-06 18:28:10.000000000

Uploaded patch set 3.

-------------------------------------
author: Braxton Mccarthy
date: 2013-12-06 18:45:13.000000000

Patch Set 3: Code-Review-1

(6 comments)

This fixes another 6 CTF tests, down to 2 now! Looking good! Some comments though.

Line:155, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/VariantDefinition.java -> sssspppaaaacccciiiing :/

Line:156, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/VariantDefinition.java -> missing NON-NLS?

Line:2039, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/metadata/IOStructGen.java -> the ':' could be part of the first string

Line:132, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/EnumDeclaration.java -> private final

Line:169, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/EnumDeclaration.java -> "Range" is a bit generic. Maybe "LabelRange"?

Line:172, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/EnumDeclaration.java -> private final

-------------------------------------
author: Brenden Conley
date: 2013-12-06 19:31:01.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4488/

-------------------------------------
author: Brenden Conley
date: 2013-12-06 20:14:07.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4488/ : ABORTED

-------------------------------------
