DESCRIPTION

RPM: createrepo plugin preferences

Added preference pages for createrepo. These preference pages will
contain the command line arguments for the createrepo command execution.

Change-Id: I80ae275264b97fed7fadffce399b6d3d55a5ece0
Signed-off-by: Tori Trevino xxx@xxx.xxx


COMMENTS

author: Tori Trevino
date: 2013-12-04 18:17:29.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-12-04 19:08:12.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4398/

-------------------------------------
author: Brenden Conley
date: 2013-12-04 19:52:58.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4398/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2013-12-05 12:03:51.000000000

Patch Set 2: Code-Review-1

(3 comments)

Line:80, rpm/org.eclipse.linuxtools.rpm.createrepo/src/org/eclipse/linuxtools/internal/rpm/createrepo/preference/CreaterepoPreferencePage.java -> No need to override and just call super.

Line:101, rpm/org.eclipse.linuxtools.rpm.createrepo/src/org/eclipse/linuxtools/internal/rpm/createrepo/preference/CreaterepoPreferencePage.java -> Why do you keep reference to parent? This is not a wise idea in general.

Line:25, rpm/org.eclipse.linuxtools.rpm.createrepo/src/org/eclipse/linuxtools/rpm/createrepo/ICreaterepoChecksums.java -> I would rather not support legacy options in new tools.

-------------------------------------
