DESCRIPTION

Systemtap: forbid invalid Run Config paths.

If the path entered in the "Systemtap Script" textbox of the Run
Configuration menu does not point to an existing .stp file, the
configuration won't be runnable.

Change-Id: Ic943931ddfcd0ae10a930b04f34cc537708b305d
Signed-off-by: Landon Wilkins xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-11-28 02:30:59.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4246/

-------------------------------------
author: Brenden Conley
date: 2013-11-28 03:17:35.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4246/ : SUCCESS

-------------------------------------
author: Nathanael Holden
date: 2013-11-28 20:59:59.000000000

Patch Set 1: Verified+1 Code-Review-1 IP-Clean+1

(2 comments)

Overall this works as I'd expect it. Just a few corner cases that need to be fixed.

Line:291, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/launcher/SystemTapScriptLaunchConfigurationTab.java -> getFileExtension() can be null if scriptPath given is a directory. I guess you'll need an extra check for this case.

Line:292, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/launcher/SystemTapScriptLaunchConfigurationTab.java -> Should this pass ? The 'return true' will be hit and the user could run the non ".stp" script.

-------------------------------------
