DESCRIPTION

ctf: Fix Integer 33-63 bit handling

* add getLong( length, signed) to bitbuffer
* add test cases for getLong

Thanks Jordon Obrien for the initial patch.

Change-Id: I388280ef111fe3fd50729780f13e984cbf648886
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2013-11-26 20:36:02.000000000

Uploaded patch set 3.

-------------------------------------
author: Ivy Mitchell
date: 2013-11-26 20:41:55.000000000

Patch Set 3:

I have commented on the code.

-------------------------------------
author: Jordon Obrien
date: 2013-11-26 20:42:14.000000000

Patch Set 3: Code-Review-1

(2 comments)

more comments.

Line:125, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/IntegerDefinition.java -> No need to do a special case for length == 64
The next case will take care of it.

Line:156, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> if (signed)

it is useless to test the bit.
It is probably more expensive to test than always shifting.

-------------------------------------
author: Ivy Mitchell
date: 2013-11-26 20:53:36.000000000

Patch Set 3:

(2 comments)

I have applied your suggestions.

Line:125, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/IntegerDefinition.java -> I have applied your suggestion.

Line:156, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> Done

-------------------------------------
author: Brenden Conley
date: 2013-11-26 20:57:59.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4182/

-------------------------------------
author: Brenden Conley
date: 2013-11-26 21:08:18.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4182/ : ABORTED

-------------------------------------
