DESCRIPTION

ctf: add getLong to bitBuffer

* add getLong to bitBuffer
* improve getInt's strictness

Change-Id: I6848b2bde4e37580c1327f03cd025ea2bae4e134
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-11-26 15:16:05.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4168/

-------------------------------------
author: Jordon Obrien
date: 2013-11-26 15:20:43.000000000

Patch Set 1: Code-Review-1

(4 comments)

getLong could be called at an un-aligned position, thus you cannot call getLong on the ByteBuffer.

Line:214, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/io/BitBufferIntTest.java -> We should add a unaligned test

Line:113, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> This is not valid when not aligned.

Line:136, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> missing space after if.

Line:139, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> missing space after if
remove space before length

-------------------------------------
author: Ivy Mitchell
date: 2013-11-26 15:36:36.000000000

Patch Set 1: Code-Review-1

(4 comments)

Line:214, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/io/BitBufferIntTest.java -> That is a good idea. I will work on that.

Line:113, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> You are correct, I will fix the problem.

Line:136, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> Done

Line:139, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> Done

-------------------------------------
author: Jordon Obrien
date: 2013-11-26 15:38:06.000000000

Patch Set 1:

(2 comments)

I missed those one.

Line:136, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> I didn;t see it, but space between) {

Line:139, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> ditto

-------------------------------------
author: Brenden Conley
date: 2013-11-26 19:11:05.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4168/ : ABORTED

-------------------------------------
