DESCRIPTION

TMF: Add new XML analysis project

Empty project where the data-driven XML analysis will be added

Change-Id: I3fc3c1ab468c601127451990bbb87dc26881f547
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2013-12-03 16:01:40.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-12-03 16:01:55.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4358/

-------------------------------------
author: Brenden Conley
date: 2013-12-03 16:47:24.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4358/ : SUCCESS

-------------------------------------
author: Ayanna Reed
date: 2013-12-03 16:50:21.000000000

Patch Set 3: Code-Review+1

Go go! review and accept this empty patch!

-------------------------------------
author: Ricky Reeves
date: 2013-12-04 17:50:59.000000000

Patch Set 3: Code-Review-1

(10 comments)

The new plug-ins should have version 1.0.0 instead of 3.0.0. Please update all relevant pom.xml files and MANIFEST.MF files.

Line:26, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui.tests/pom.xml -> UI (upper case)

Line:46, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui.tests/pom.xml -> true

Line:3, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/pom.xml -> Copyright is not ok

Line:15, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui.tests/plugin.properties -> Add UI:
Linux Tools TMF Xml Analysis UI Tests Plug-in

Line:4, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/build.properties -> about.html file is missing and needs to be added in bin.includes and src.includes. Copy it from it tmf.core plug-in

Line:19, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/tests/AllAnalysisXmlUiTests.java -> ... for TMF UI Xml ...

Line:5, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/build.properties -> about.html file is missing and needs to be added in bin.includes and src.includes. Copy it from it tmf.core plug-in

Line:4, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/pom.xml -> Copyright is not ok

Line:4, lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/pom.xml -> Copyright is not ok

Line:21, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/tests/XmlAnalysisUiPluginTest.java -> UI (Uppercase)

-------------------------------------
author: Annalise Jimenez
date: 2013-12-04 19:30:31.000000000

Patch Set 3:

Shouldn't they have the same version as the rest of TMF?  It is OK for them to be 2 versions lower than the rest of the plug-ins?

-------------------------------------
author: Ricky Reeves
date: 2013-12-04 20:30:26.000000000

Patch Set 3:

no, it is ok to have plug-ins with lower version than the feature or other plug-ins.

-------------------------------------
