DESCRIPTION

[ctf] Fix multiple coding style and typo issues while reading code.

Change-Id: If63330f4c86e7cd87cf979e1709a81fb7c8958ab
Signed-off-by: Jordon Obrien xxx@xxx.xxx


COMMENTS

author: Jordon Obrien
date: 2013-11-24 06:20:13.000000000

Uploaded patch set 10.

-------------------------------------
author: Brenden Conley
date: 2013-11-24 06:45:11.000000000

Patch Set 10:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4117/

-------------------------------------
author: Brenden Conley
date: 2013-11-24 07:18:12.000000000

Patch Set 10: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4117/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2013-11-25 16:00:11.000000000

Patch Set 10: Verified+1 Code-Review+1

(1 comment)

I am OK with this + 1 minor nit that even is not in the patch per se. 

That being said, I am very uncomfortable with no names in the copyright header. Etienne, you don't need to change your code, yet, I may submit a patch later, I will consult with the team to see if I am being to harsh.

Line:84, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/trace/StreamInputPacketIndex.java -> asserts can be flat out removed. This was coded back when I though java and C are the same thing. :(

-------------------------------------
author: Jordon Obrien
date: 2013-11-25 16:06:04.000000000

Patch Set 10:

My opinion on authors is: add them when they contribute a non trivial piece of code and will maintain it.

For the copyright, I believe I give my rights to the project by adding the "signed-by" and signing the CLA.
Correct me if I'm wrong.

-------------------------------------
author: Ricky Reeves
date: 2013-11-26 15:33:47.000000000

Patch Set 10: Code-Review+1

Hi Etienne and Matthew

Some general comments about author and copyright.

> For the copyright, I believe I give my rights to the project
> by adding the "signed-by" and signing the CLA. Correct me if
> I'm wrong.

By adding the "signed-by" and signing the CLA you indicate that the contribution is in compliance with the Eclipse Foundation Contributor’s Certificate of Origin (see http://www.eclipse.org/legal/CoO.php)

The Copyright line in the copyright header indicates who are the copyright owners. (see http://www.eclipse.org/legal/copyrightandlicensenotice.php). For your case you have to know if it is you or your Employer. 

Adding yourself to the Contributors in the header, indicates that you wrote the contributed code but doesn't mean you are the copyright owner. 

This particular contribution fixes coding style and typos. I don't think it is copyrightable. 

Since you don't see the need to add you name to the name of contributors for these files I'm ok to push it as is.

-------------------------------------
author: Jordon Obrien
date: 2013-11-26 15:35:58.000000000

Patch Set 10:

Thanks for the information.

-------------------------------------
author: Ivy Mitchell
date: 2013-11-26 15:38:07.000000000

Patch Set 10: Code-Review+2 IP-Clean+1

-------------------------------------
author: Gerrit Code Review
date: 2013-11-26 15:38:08.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
