DESCRIPTION

TMF: Port the LTTng Kernel state system to an analysis module

And update the views accordingly.

Change-Id: I90975b5772db24a784d99d2d0232f6f76a8e5e03
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2013-11-25 23:33:09.000000000

Uploaded patch set 5.

-------------------------------------
author: Braxton Mccarthy
date: 2013-11-25 23:33:41.000000000

Patch Set 5:

Straight rebase to lttng-luna head. No conflicts.

-------------------------------------
author: Brenden Conley
date: 2013-11-26 02:28:26.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4152/

-------------------------------------
author: Ricky Reeves
date: 2013-11-26 02:53:17.000000000

Patch Set 5: Code-Review-1

(1 comment)

I noticed that the help message of the Analysis module shows an empty string and not the help text defined in the analysis module.

I also noticed that the StateSystem.ht doesn't show up when calling delete suppl. files right after it is built. I had to press F5 (refresh) on the project first.

I also get a NPE when closing the trace while the state system is being built:
 java.lang.NullPointerException
	at org.eclipse.linuxtools.tmf.core.statesystem.TmfStateSystemAnalysisModule.canceling(TmfStateSystemAnalysisModule.java:136)
	at org.eclipse.linuxtools.tmf.core.analysis.TmfAbstractAnalysisModule$1.canceling(TmfAbstractAnalysisModule.java:279)
	at org.eclipse.core.internal.jobs.JobManager.cancel(JobManager.java:320)
	at org.eclipse.core.internal.jobs.InternalJob.cancel(InternalJob.java:187)
	at org.eclipse.core.runtime.jobs.Job.cancel(Job.java:195)
	at org.eclipse.linuxtools.tmf.core.analysis.TmfAbstractAnalysisModule.cancel(TmfAbstractAnalysisModule.java:223)
	at org.eclipse.linuxtools.tmf.core.analysis.TmfAbstractAnalysisModule.traceClosed(TmfAbstractAnalysisModule.java:333)
	... 81 more

Line:70, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/plugin.xml -> pls put name into plugin.properties file

-------------------------------------
author: Brenden Conley
date: 2013-11-26 03:10:56.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4152/ : SUCCESS

-------------------------------------
author: Annalise Jimenez
date: 2013-11-27 20:10:47.000000000

Patch Set 5:

About the help point, I think I'll just disable it for now, at least for closed traces.  It could work only for open traces. Indeed for closed traces, the module is not instantiated and the helper does not know about the help message.

When I have time to work on the next phase of the analysis module, I intend to integrate the help with Eclipse Help, so clicking help will open a help page for this module.

-------------------------------------
