DESCRIPTION

lttng: Add possibility to select/deselect all in remote import dialog

Change-Id: I41c32e3d214b422795679ba1d2e425eb8af58e5b
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-11-05 20:02:37.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3834/

-------------------------------------
author: Brenden Conley
date: 2013-11-05 20:40:02.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3834/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2013-11-06 22:18:57.000000000

Patch Set 1: Verified-1 Code-Review-1

(2 comments)

Line:203, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/ImportDialog.java -> Could you use a "foreach" here?
for (Object child : fFolderChildren)

I think you can do that in a few places in this file.

Line:390, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/ImportDialog.java -> updateOKButtonEnablement needs to be called as part of this event. If I click Deselect All then manually select a trace in the tree, the OK button stays disabled. Similarly, if I open the dialog, by default everything is selected but if I manually deselect the element, the OK button is not disabled.

-------------------------------------
author: Ricky Reeves
date: 2013-11-07 17:05:28.000000000

Patch Set 1:

(2 comments)

Line:203, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/ImportDialog.java -> Done

Line:390, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/ImportDialog.java -> Done

-------------------------------------
