DESCRIPTION

TMF: Add base class and interface for state system analysis

Also update the state system explorer to show state systems from modules
instead.

Change-Id: Iab6424be1a469c541d3e9b199d7377c8a4e70299
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2013-11-14 22:09:40.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2013-11-14 22:09:45.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3940/

-------------------------------------
author: Brenden Conley
date: 2013-11-14 22:32:01.000000000

Patch Set 5: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3940/ : FAILURE

-------------------------------------
author: Braxton Mccarthy
date: 2013-11-14 23:16:35.000000000

Patch Set 5: Code-Review-1

(12 comments)

Hudson seems to be back to life, next patch should (hopefully) work.

Line:330, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> specific what? (time range?)

Line:17, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/ITmfStateSystemAnalysisModule.java -> remove one empty line

Line:19, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/ITmfStateSystemAnalysisModule.java -> who provide -> providing

Line:26, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/ITmfStateSystemAnalysisModule.java -> Mention what <String, ITmfStateSystem> are for. I assume String is the ID?

Line:36, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> you can put the 'implements ...' part on a separate line

Line:46, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> maybe call this StateSystemBackendType, since it's not the backend object per se.

I like this approach of the enum for type.

Line:88, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> here too, this should be getBackendType()

Shouldn't this be an abstract method too?

Line:97, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> createStateProvider() should not return null... we could add xxx@xxx.xxx annotation to the method ;)

Line:109, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> I'd repeat the two above lines in each case, and remove the if below, it'd be easier to understand the flow.

Line:448, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java -> You can add a SuppressWarning to suppress the warning (nothing we can do atm to fix it)

Line:458, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java -> here too

Line:265, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java -> We could still restrict T to IAnalysisModule, since modules have to implement that interface anyway (in addition to stuff like ITmfStateSystemAnalysis, optionally).

-------------------------------------
author: Annalise Jimenez
date: 2013-11-15 13:58:34.000000000

Patch Set 5:

(2 comments)

Line:330, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> I don't know, who wrote this? :p

Line:265, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java -> The idea of this method is to return objects with the correct type already, so if I want ITmfStateSystemAnalysis because I want to call the getStateSystems method, then I don't want them already cast.  All objects will of course also implement IAnalysisModule, but that's not what we're using this function for.

-------------------------------------
