DESCRIPTION

tmf: Fix SD unit test with GTK3

Using a very recent Eclipse integration build (which now uses the GTK3 SWT
backend), one of the Sequence Diagram unit tests fails because of invalid
parameter values.

This patch fixes the test by clamping the height/width area values to 1.
It also fixes an instance of messing with Exception.

Change-Id: Idccbb3490e6a0ed9dc83c1f7582c61251ec09142
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2013-10-29 20:37:19.000000000

Patch Set 1:

(1 comment)

Line:1336, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/uml2sd/SDWidget.java -> What do you think of using Math.max(area.width, 1) ? that would be one line

-------------------------------------
author: Braxton Mccarthy
date: 2013-10-29 21:12:44.000000000

Patch Set 1:

(1 comment)

Line:1336, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/uml2sd/SDWidget.java -> But less LOCs means we do less work, right, right?

-------------------------------------
author: Brenden Conley
date: 2013-10-29 21:58:19.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3788/

-------------------------------------
author: Brenden Conley
date: 2013-10-29 22:31:38.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3788/ : SUCCESS

-------------------------------------
