DESCRIPTION

tmf: update batch import wizard to show file sizes

Change-Id: I970c569860f81a2bd33a3ab227aa7ff3db2679b8
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2013-10-25 17:29:48.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-10-25 17:29:54.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3763/

-------------------------------------
author: Brenden Conley
date: 2013-10-25 18:14:11.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3763/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2013-11-17 22:13:17.000000000

Patch Set 2: Verified+1 Code-Review-1 IP-Clean+1

(2 comments)

Some minor comments. Works well!

Line:37, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/Messages.java -> I get xxx@xxx.xxx errors here.

Line:203, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardScanPage.java -> can you rename this parameter to file? Because it's not necessary a dir but a file can be a dir... from Java's point of view.

-------------------------------------
author: Kaeden Tapia
date: 2013-11-17 22:15:07.000000000

Patch Set 2:

(1 comment)

Line:212, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardScanPage.java -> I think this should be file.canRead() here, right?

-------------------------------------
