DESCRIPTION

tmf: batch import wizard smoke test

This is a sample of how to make a test using SWTBOT.
It is not elegant, yet. It may be useful to gain
test case coverage.

The test features:
* a kernel trace generator
* importing a trace
* opening a trace
* navigation in a trace

What would be nice to have:
* closing a trace
* all the other unit traces!

Change-Id: I91e258ed5fb7735287da303d518314460839547b
Signed-off-by: Ivy Mitchell xxx@xxx.xxx

Conflicts:
	lttng/org.eclipse.linuxtools.tmf.ui.tests/META-INF/MANIFEST.MF


COMMENTS

author: Brenden Conley
date: 2013-10-03 14:20:55.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3621/

-------------------------------------
author: Brenden Conley
date: 2013-10-03 15:01:04.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3621/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-10-03 17:56:43.000000000

Patch Set 1: Code-Review-1

(16 comments)

Looks promising!

The changes in the tmf.ui.importtrace package should be done in a separate patch. Also, comments

Line:27, /COMMIT_MSG -> TA DA DUM!

*Always* remove those extra lines before pushing to Gerrit... now you can see Gerrit didn't parse the Change-Id line, so it assigned a different change-id to this patch.

Next patch remove the Conflicts line, and update the Change-Id to match the one Gerrit gave.

Line:70, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> line. Also add descruption

Line:80, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> Might as well add a "Test class setup"

Line:87, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> Perhaps put more actually-useful comments. Like what each block does (initialize the bot, crank up the bot, let the bot run wild, etc.)

Line:134, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> Where is the code, you said there would be code

Line:200, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> remove empty line

Line:272, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> Don't keep commented blocks in the final version.

This looks interesting though, any way to make it work?

Line:410, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/SmokeTest.java -> private methods don't need javadoc, might as well not put any if it doesn't add anything

Line:20, lttng/org.eclipse.linuxtools.tmf.ui.tests/META-INF/MANIFEST.MF -> Add those to the target definitions (in o.e.l.lttng.target). So that we can actually try it ;)

Line:21, lttng/org.eclipse.linuxtools.tmf.ui.tests/META-INF/MANIFEST.MF -> The other org.eclipse.{core|ui} dependencies are not versioned, this one shouldn't be either.

Also move them up with the other eclipse.ui dep.

Line:32, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/headless/ReadTrace.java -> Don't commit this

Line:23, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/GenerateTrace.java -> argfhgfh

Line:36, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/GenerateTrace.java -> tss you're gonna jinx it!

Line:26, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/GenerateKernelTrace.java -> Add a line before the xxx@xxx.xxx

Line:28, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/GenerateKernelTrace.java -> This line here. This extra line that gets added by the default auto-formatter. It annoys me to no end. Remove it.

Line:31, lttng/org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/smoketest/GenerateKernelTrace.java -> Any reason why you couldn't re-use one of the many test traces we already have?

-------------------------------------
author: Ivy Mitchell
date: 2013-10-04 21:01:55.000000000

Abandoned

change-id error

-------------------------------------
