DESCRIPTION

Systemtap: Prevent running scripts if existing graphs are missing required columns.

In Run Configurations->Graphing, deleting a parsing column that a created graph
relies on now counts as an error in a Run Configuration, and UI notifies users of
such an error when it is present.

A regular expression without any parenthesized groups also now counts as an error,
and graphs can't be added unless at least one such group exists.

Change-Id: Ibe6d11fad66c8b60ea40cd4faccb7cdf7749d18a
Signed-off-by: Landon Wilkins xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-10-02 18:15:39.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3599/

-------------------------------------
author: Erick Ross
date: 2013-10-02 18:22:03.000000000

Patch Set 4:

(4 comments)

Line:228, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/wizards/graph/SelectGraphAndSeriesWizardPage.java -> Please use parenthesis for for statements.

Line:234, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/wizards/graph/SelectGraphAndSeriesWizardPage.java -> Missing parenthesis again

Line:248, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/wizards/graph/SelectGraphAndSeriesWizardPage.java -> Missing parenthesis and using String.isEmpty is better.

Line:249, systemtap/org.eclipse.linuxtools.systemtap.graphingapi.ui/src/org/eclipse/linuxtools/systemtap/graphingapi/ui/wizards/graph/SelectGraphAndSeriesWizardPage.java -> Missing parenthesis again.

-------------------------------------
author: Brenden Conley
date: 2013-10-02 18:46:16.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3599/ : SUCCESS

-------------------------------------
