DESCRIPTION

Bug 417036 - [TMF] Legacy import: Trace type is not set after importing custom trace

Change-Id: I1db889718bf5985b6b0e3ae6395dd958a399ef6e
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-09-11 19:35:15.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3438/

-------------------------------------
author: Nathanael Holden
date: 2013-09-11 19:44:37.000000000

Patch Set 1:

Unfortunately the hudson build will likely fail due to 34a1847956b7f6ef8400ef69ea760e3719920700 on master. Basically, if any commit that introduces a test failure makes it into master, all other gerrit builds will fail (on master, and kepler we allow the build to still pass on test failures).

If you don't see this commit introducing a test failure and don't want to wait you can always push before hudson finishes rebuilding it.

-------------------------------------
author: Brenden Conley
date: 2013-09-11 20:03:40.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3438/ : FAILURE

-------------------------------------
author: Luciana Barry
date: 2013-09-11 21:18:43.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:735, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java -> You could use TmfTraceType.SEPARATOR instead, it will ensure they are aligned.

Line:738, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java -> Here too

-------------------------------------
author: Kaeden Tapia
date: 2013-09-11 21:31:59.000000000

Patch Set 1:

(1 comment)

Line:735, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java -> Unfortunately, this is private, but I can at least extract the constant in this class.

-------------------------------------
