DESCRIPTION

tmf : xml state provider as a module of the analysis framework.

Initial Commit for the XML state provider. Add a esay way to make new
State System in TMF.

Change-Id: I7a1a970e4044a694e457d57ba496b69f4f07c20e
Signed-off-by: Ayanna Reed xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-09-09 21:31:39.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3412/

-------------------------------------
author: Brenden Conley
date: 2013-09-09 21:32:06.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3412/ : FAILURE

-------------------------------------
author: Annalise Jimenez
date: 2013-09-19 20:02:10.000000000

Patch Set 2: Code-Review-1

(12 comments)

Only checked the xml.tests module, will do the rest tomorrow, but some formatting errors (probably my fault anyway).

Also the Brenden Conley build failed.  If you're sure it's not your code, then just push the patch again (Hudson jobs sometimes have problems like that).  But patches won't be reviewed as long as there's a fail for Hudson CI.

Line:22, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/tests/module/AllTests.java -> Ctrl-alt-F

Line:30, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/tests/module/XmlAnalysisModuleTest.java -> Ctrl-alt-F
I know.  This is probably my own code that I gave you without formatting, but it was expected to be filled with some unit tests! :p

Line:296, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:297, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:409, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:457, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:466, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:467, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:563, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:564, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/test_xml_files/test_valid.xml -> extra white space at the end

Line:30, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/tests/module/XmlUtilsTest.java -> Ctrl-alt-F this file too

Line:26, lttng/org.eclipse.linuxtools.tmf.analysis.xml.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/tests/AllTmfAnalysisXmlTests.java -> whitespaces Ctrl-alt-F

-------------------------------------
author: Annalise Jimenez
date: 2013-09-20 19:50:21.000000000

Patch Set 2:

(29 comments)

More comments on the rest of the patch.  Again many redundant boring formatting comments.

I'll correct some of those next week.  I'll leave you the method descriptions since they can (and sometimes should!) be a little more verbose than "Get the condition" for a getCondition method ;-)  You know better than I what they really do.

Line:34, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlStateValue.java -> extra blank line

ctrl-alt-f file with pre-formatted text inside <pre></pre> tags

Check missing method description

Line:37, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlCondition.java -> extra blank line

Line:44, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlCondition.java -> Missing method description

Line:38, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlEventHandler.java -> extra blank line

Line:46, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlEventHandler.java -> missing method description
ctrl-alt-f

Line:69, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlEventHandler.java -> missing method description

Line:76, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlEventHandler.java -> idem

Line:30, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> If you don't want this text to be formatted when ctrl-alt-f the file, put it between <pre></pre> tags and the formatting will ignore it

Line:35, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> extra blank line

Line:63, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> Ctrl-alt-f

Line:78, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> Add method description

Line:85, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> Add method description

Line:92, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> Method description

Line:105, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> Add parameter descriptions

Line:119, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlAttribute.java -> Ctrl-alt-f everywhere

Line:34, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlLocation.java -> extra blank line

ctrl-alt-f file with pre-formatted text inside <pre></pre> tags

Check missing method description

Line:53, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/model/XmlStateChange.java -> extra blank line

ctrl-alt-f file with pre-formatted text inside <pre></pre> tags

Check missing method description

Line:42, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/module/xmldefinition.xsd -> extra tab

Line:58, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/module/xmldefinition.xsd -> extra tab

Line:16, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/internal/tmf/analysis/xml/Activator.java -> No tabs, only spaces

Line:72, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/module/XmlUtils.java -> Errors should be logged in the Activator instead of dumped to System console

Line:3, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> Don't put your name for the coyright, you're a contributor, that's enough
Idem for other file's headers

Line:44, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> Rephrase this

Line:59, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> To save some space, you may put those small comments inline /** State ID */, but that's ok

Line:70, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> Naming convention for the fields is to start with f, so here fStateValues.  Same for fields above

Line:91, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> Ctrl-alt-F

Line:150, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> Need a method description, even if it is obvious from name

Line:178, lttng/org.eclipse.linuxtools.tmf.analysis.xml/src/org/eclipse/linuxtools/tmf/analysis/xml/stateprovider/XmlAbstractProvider.java -> ctrl-alt-f, likewise for futher javadoc param descriptions

Line:195, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/analysis/TmfAnalysisManager.java -> Note to self: I don't think it's the right way to do this, the manager shouldn't know about the analysis class.  Maybe ask to return a list of analysis of a given type? and put this kind of method in the appropriate module?

-------------------------------------
author: Braxton Mccarthy
date: 2013-11-14 19:00:04.000000000

Abandoned

Geneviève said to abandon

-------------------------------------
