DESCRIPTION

Fix to execute RPM commands through the proxy for remote to work

Change-Id: I95e830d0b46aa4bfd2af15882594d33f19e67a4d


COMMENTS

author: Craig Arias
date: 2013-08-29 19:34:22.000000000

Uploaded patch set 4.

-------------------------------------
author: Callum Holloway
date: 2013-08-31 05:05:16.000000000

Patch Set 4: Verified+1 Code-Review+1 IP-Clean+1

-------------------------------------
author: Erick Ross
date: 2013-09-02 23:21:06.000000000

Patch Set 4:

(4 comments)

Line:18, rpm/org.eclipse.linuxtools.rpm.core/META-INF/MANIFEST.MF -> I would really prefer if from now on the rpm plugin relies on Require-Bundle instead of Import-Package as the former is automatable on rpm level and the later is not.

Line:81, rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/outline/SpecfileContentOutlinePage.java -> This would be better as
 SpecfileLabelProvider labelProvider = new SpecfileLabelProvider();
		if (project!=null) {
			labelProvider.setProject(project);
		} 
		viewer.setLabelProvider(labelProvider);

Line:95, rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/outline/SpecfileLabelProvider.java -> Do we need this method public ? The place where it's used is in the same package so protected/default should work ?

Line:54, rpm/org.eclipse.linuxtools.rpm.core/src/org/eclipse/linuxtools/rpm/core/utils/Utils.java -> Please don't push trailing whitespaces.

-------------------------------------
author: Erick Ross
date: 2013-09-02 23:22:40.000000000

Patch Set 4:

(1 comment)

Line:28, rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/outline/SpecfileLabelProvider.java -> This import is not used at all, please drop it.

-------------------------------------
