DESCRIPTION

TMF: User and developer documentation for trace synchronization

Change-Id: Ibbd6c16e08a12ccf065a9b57c4db99eef354f787
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2013-09-25 19:24:55.000000000

Uploaded patch set 2.

-------------------------------------
author: Braxton Mccarthy
date: 2013-09-25 19:25:36.000000000

Patch Set 2:

I just ran the .png's through optipng, saved around 30% space.

-------------------------------------
author: Brenden Conley
date: 2013-09-25 20:09:15.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3551/

-------------------------------------
author: Braxton Mccarthy
date: 2013-09-25 20:16:27.000000000

Patch Set 2:

(36 comments)

Oh noes, I just did a review on patch set 2. Oh well, hopefully there's still some relevant stuff...

File Comment: lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> Here too, whitespaces + 1 space after periods

Line:1586, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> the same timestamps as usual

Line:1590, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> data and content are redundant here, use one of those words

Line:1596, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> The tracepoints '''net_dev_queue'''...

as-is

Line:1602, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> I haven't looked at the compiled version yet, but is this formatted nicely? Would it need <pre> tags?

Line:1605, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> Checkout the "net_data_experimental" branch (slightly less confusing)

Line:1612, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> , but

Line:1616, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> TCP

Line:1632, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> TCP

Line:1656, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> named after the original

a '_'  (or "an underscore")

, and the original trace

Line:1660, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> presents

capitalize Control Flow View

after the time synchronization

Line:1662, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> Control Flow View

Line:1664, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> quality of the synchronization

'''Synchronization''' view (capital)

Line:2887, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> Haha I see whitespace!

Also, put only one space after periods, to be consistent with the rest of the file.

Line:2889, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> consists

timestamps

Line:2905, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> "from which to match events" -> from which events are matched, maybe?

put handleData in '' '' too.

need -> needs

Line:2907, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> a ''in'' event, a ''out'' event

destination event -> destination events

Line:2917, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> previous event

Line:2921, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> is a ''in'' or ''out'' event

Line:2923, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> are have been -> have been (you accidentally an extra word)

tcp -> TCP

See User-Guide... -> See the LTTng User Guide, maybe

metadata of a CTF trace

Line:2927, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> functionality (thanks to Firefox auto-correct)

Line:2931, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> For example, (add comma)

through such a processing unit

Line:2935, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> Use -> Using

Line:2937, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> "matchEvents" is in one word right? Gerrit seems to have split it weirdly.

Line:2942, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> Reviewing code in doc now :P

field should be private.

Line:3012, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> UST

Line:3016, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> describes

Line:3044, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> and -> an

Line:3108, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> they all use the same time reference

typically,

traces from different machines

the result is a best approximation that takes network latency into account.

Line:3114, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> provisions. or "is provisioned". not sure...

Line:3130, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> change over the course

Line:3134, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> remove "but"

Line:3137, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> Maybe plug a reference here, like her article

Line:3138, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> one of the traces

on the same machine

Line:3140, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> the synchronization information

Line:3144, lttng/org.eclipse.linuxtools.tmf.help/doc/Developer-Guide.mediawiki -> is that the end of the file? You only need one empty line then

-------------------------------------
author: Brenden Conley
date: 2013-09-25 20:40:55.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3551/ : SUCCESS

-------------------------------------
