DESCRIPTION

Bug 415710: 'perf' check should explicitly handle a null process.

A null process usually indicates the command could not be found. In
addition, the RuntimeProcessFactory#whichCommand should safely handle an
empty standard output stream without relying on exception catching.

Change-Id: Ifa26f211af8815e8db7a404e856cdb4220a35857


COMMENTS

author: Nathanael Holden
date: 2013-08-28 15:06:37.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-08-28 15:06:43.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/3303/

-------------------------------------
author: Kaeden Tapia
date: 2013-08-28 15:35:00.000000000

Patch Set 3: Code-Review-1

(1 comment)

Line:111, profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/RuntimeProcessFactory.java -> This line still throws IndexOutOfBoundsException.

-------------------------------------
author: Brenden Conley
date: 2013-08-28 15:50:53.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/3303/ : SUCCESS

-------------------------------------
author: Nathanael Holden
date: 2013-08-28 19:25:52.000000000

Patch Set 3:

(1 comment)

Line:111, profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/RuntimeProcessFactory.java -> Yikes, that was silly of me. I'll fix it.

-------------------------------------
author: Gerrit Code Review
date: 2013-08-29 20:30:10.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
