DESCRIPTION

[RFC] Add base classes for XY charts based on SWT charts

- Add Base XY Chart Viewer
- Add Bar Chart Viewer
- Add default mouse drag and mouse wheel provider
- Add default selection provider
- Add default tool tip provider
- Add tool tip provider for bar charts
- Add Base chart view
- Support for current time and time range synchronization
- Support for open, select and close trace synchronization
- Add example plug-in with implementation of a histogram
- Add XY Line Chart Viewer

Implementation based on proposal for new histogram with SWT chart
by Braxton Mccarthy (https://git.eclipse.org/r/#/c/9231).
Thanks also to Ivy Mitchell for suggestions on how to avoid
loss of precision when converting long <-> double values. Geneviève
Bastien added the abstract xy line chart viewer.

Change-Id: I4c44de7d0cb062c4f085d5494bf5f3f5f92c4a8a
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2013-12-16 21:32:59.000000000

Uploaded patch set 6.

-------------------------------------
author: Annalise Jimenez
date: 2013-12-16 21:47:22.000000000

Patch Set 6: Code-Review-1

Oups, I hadn't seen Alex's comment on this patch and just added yet one more little patch inside this one ;-)

Meredith Scott, Alex, will you take care of splitting it? Or I can do it tomorrow if that can help. That will make it easier, I haven't really looked at the histogram yet and that all need to be looked at before being merged.

By the way, if you can take a quick look at BarChartViewer vs XYLinePlotViewer. They are a bit different in method names and task separation, but I think they should be more alike. I'd like some feedback before unilaterally selecting one option above the other.

-------------------------------------
author: Annalise Jimenez
date: 2013-12-16 21:48:20.000000000

Patch Set 6:

(1 comment)

Line:40, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/ui/viewers/histogram/NewHistogramViewer.java -> I ctrl-alt-f'ed it and this is what it looks like :(
Any missing settings to the project?

-------------------------------------
author: Brenden Conley
date: 2013-12-16 22:14:38.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4713/

-------------------------------------
author: Brenden Conley
date: 2013-12-16 22:15:29.000000000

Patch Set 6: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/4713/ : FAILURE

-------------------------------------
author: Braxton Mccarthy
date: 2013-12-17 20:20:31.000000000

Patch Set 6:

(1 comment)

Line:40, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/ui/viewers/histogram/NewHistogramViewer.java -> Yes, the auto-format settings are set as project-specific settings too. Make sure you copy over all the files in .settings/ from another "real" plugin, like tmf.core.

-------------------------------------
author: Ricky Reeves
date: 2013-12-18 12:31:05.000000000

Patch Set 6:

Hi Genevieve

thanks for updating this patch. I'll take a look. I'm going to split the patch in smaller patch sets as Alex suggested. BTW, I was working on updating the the selection handling with the left mouse and the drag zoom with the right mouse. This will be part of the set of patches. 

Meredith Scott

-------------------------------------
author: Ricky Reeves
date: 2013-12-19 20:48:03.000000000

Patch Set 6: Code-Review-2

This patch is replaced by multiple patches starting with https://git.eclipse.org/r/#/c/20079/

-------------------------------------
author: Annalise Jimenez
date: 2013-12-19 20:56:59.000000000

Patch Set 6:

oh yeah! But I don't see my line chart in those patchsets. You give me the honour of pushing this extra patch?

-------------------------------------
author: Braxton Mccarthy
date: 2014-01-10 21:59:02.000000000

Abandoned

This was split in smaller patches, and most of it is already in master.

-------------------------------------
