DESCRIPTION

rcp(battrace?): add babeltrace-like functionality.

the --NOUI flag works now

Change-Id: I8b904ded73ab4a6bafc644752a68f9a6d632b04b
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2013-07-16 21:38:24.000000000

Uploaded patch set 2.

-------------------------------------
author: Kaeden Tapia
date: 2013-07-17 03:29:42.000000000

Patch Set 2: Code-Review-1

(7 comments)

Line:43, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/commands/TextDump.java -> to the standard output

Line:79, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/commands/TextDump.java -> I think this should be generic and not just for Ctf. Each trace type could print to standard output the way they want.

Line:86, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/commands/TextDump.java -> Isn't this always going to be true?

Line:94, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/commands/TextDump.java -> Add API for this? (see previous comment about making it generic) Either at the trace level or the event level, depending how much flexibility we want to leave.

Line:78, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/TracingRcpPlugin.java -> babelTrace? Is that a verb? ;) I think this method needs a better name than what it's trying to mimic.

Line:79, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/TracingRcpPlugin.java -> Have you tried PlatformUI.getWorkbench().close(); ?

Line:275, lttng/org.eclipse.linuxtools.tracing.rcp.ui/src/org/eclipse/linuxtools/internal/tracing/rcp/ui/commands/OpenTraceHelper.java -> promptForTraceType?

-------------------------------------
author: Ivy Mitchell
date: 2013-07-30 13:27:42.000000000

Patch Set 2:

On hold until we see a business value to this load of drek.

-------------------------------------
author: Ivy Mitchell
date: 2014-08-19 17:14:30.000000000

Abandoned

Joker won

-------------------------------------
