DESCRIPTION

LTTng: Support for LTTng Tools 2.2

Change-Id: Ib87e9e5598f8b7caad42b1e780f8cddb8aeee4d2
Signed-off-by: Kelsie Blackwell xxx@xxx.xxx

COMMENTS

author: Kelsie Blackwell
date: 2013-07-26 19:28:21.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-07-26 19:28:26.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2985/

-------------------------------------
author: Brenden Conley
date: 2013-07-26 19:42:49.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2985/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2013-07-29 12:57:46.000000000

Patch Set 3: Verified-1 Code-Review-1

(9 comments)

Features work. However, some modification of EnableChannelDialog needed.

Also, LTTngControlServiceTest has failures.

Line:938, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> Update this chapter with the new way of handling the default values.

Line:60, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/EnableChannelDialog.java -> constant -> change to private static final

Also, I prefer the string <default> better. Cool would be also if the default String would be written in a light grey and only valid number are written in the normal color.

Line:399, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/EnableChannelDialog.java -> A NumberFormatException exception is created when the user deleted 1 or more character of the String Default and the pressed Ok. Even when the field is empty this happens. (Same thiing for the other parameters below)

We need to be more robust. To best solution is to avoid having any non-numbers in the fields. So, this we could do:

When the user clicks into the field then the default string will be removed (if needed) and the number the user is typing will be written. When field is empty and filed looses focus then the default string is shown again.

Line:579, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> Move the unused value to LTTngControlServiceConstants.java.

Line:585, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> please remove the line for default.

Line:591, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> please remove (default: 0)

Line:597, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> please remove (default: 200)

Line:609, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> please remove (default: 0)

Line:615, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> please remove (default: 0)

-------------------------------------
author: Gerrit Code Review
date: 2013-07-30 14:21:01.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
