DESCRIPTION

LTTng: Support for LTTng Tools 2.2

Change-Id: Ib87e9e5598f8b7caad42b1e780f8cddb8aeee4d2
Signed-off-by: Kelsie Blackwell xxx@xxx.xxx

COMMENTS

author: Kelsie Blackwell
date: 2013-07-04 19:44:54.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-07-04 19:45:00.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2847/

-------------------------------------
author: Brenden Conley
date: 2013-07-04 19:58:49.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2847/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2013-07-25 13:30:41.000000000

Patch Set 2: Code-Review-1

(7 comments)

Line:967, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> typo: change to "is used"

Line:976, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> UST traces

Line:986, lttng/org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki -> remove trailing space

Line:456, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/EnableChannelDialog.java -> The default values on the tracer side changed for LTTng 2.2.
Now, the default value depends on kernel or ust-pid or ust-uid or metadata. I wonder if we should change the implementation of the Dialog box and the command execution so that we pass only a value for the parameters if the user enters a value in the text box. Otherwise if text box is empty this particular parameter is not passed to enable-channel command. 

What do you think? Let's talk about it in our daily meeting.

Line:128, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/messages/messages.properties -> The tooltip is not entirely correct for LTTng 2.2. The sentence "Needs to be a power of 2 ..." is only valid for older versions.

Line:129, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/messages/messages.properties -> The tooltip is not entirely correct for LTTng 2.2. The sentence "Needs to be a power of 2 ..." is only valid for older versions.

Line:78, lttng/org.eclipse.linuxtools.lttng2.core/src/org/eclipse/linuxtools/internal/lttng2/core/control/model/impl/ChannelInfo.java -> rename to fIsBuffersUID, since variable is a boolean

-------------------------------------
author: Gerrit Code Review
date: 2013-07-30 14:21:01.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
